Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad GCP environment variable example #101

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

lukebarton
Copy link
Contributor

Small change to some example values.

Trusting this example cost me a couple hours debugging so I hope to save other travellers from the same pain 🙌

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2019

CLA assistant check
All committers have signed the CLA.

@jasonodonnell jasonodonnell self-requested a review October 28, 2019 15:55
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @lukebarton, thanks!

@jasonodonnell jasonodonnell merged commit 04303ba into hashicorp:master Oct 28, 2019
radudd pushed a commit to radudd/vault-helm that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants