Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for namespaces #44

Merged
merged 5 commits into from Jun 8, 2020
Merged

Add support for namespaces #44

merged 5 commits into from Jun 8, 2020

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Jun 8, 2020

Support was added in the Vault API module.

Fixes #42

Support was added in the Vault API module.
@kalafut kalafut requested a review from vishalnayak June 8, 2020 16:14
// to Vault. In case of errors, this can be used for debugging.
//
// If mount point is not mentioned in the config file, default mount point
// of the SSH backend will be used.
log.Printf("[INFO] using SSH mount point: %s", clientConfig.SSHMountPoint)
log.Printf("[INFO] using namespace: %s", clientConfig.Namespace)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to do a client.SetNamespace to be able to actually use the new config field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client object returned from the API already has it set. I was a bit surprised to find all the config parsing and setup for this utility being doing in the API module and not here. hashicorp/vault@eb666e9#diff-5524bc23fc3211255e85bfe799553592R129

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Remembered looking at it too. Yeah. This code was written a long time ago :-)

@kalafut kalafut merged commit 4eaeb3a into master Jun 8, 2020
@kalafut kalafut deleted the namespace-support branch June 8, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace (Vault Enterprise) support
2 participants