Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the passwords masked while typing them in the UI #6435

Closed
hmalphettes opened this issue Mar 19, 2019 · 5 comments
Closed

Keep the passwords masked while typing them in the UI #6435

hmalphettes opened this issue Mar 19, 2019 · 5 comments

Comments

@hmalphettes
Copy link
Contributor

Hi everyone, when lodging credentials in Vault via the UI, the credentials appear in clear when the input field is in focus.

Would we consider a switch or a UI configuration setting to mask the values as they are being typed?

In my situation we often open a screenshare where a team entrusted with retrieving passwords is in charge of entering them into other systems but it is required that no one can see the passwords in clear during that operation.

This is somewhat a follow-up on #4759

Is this something interesting for the rest of the community?

Thanks for your kind attention!

@hmalphettes
Copy link
Contributor Author

For implementation we could use a font that renders an identical square glyph for every character.
For example: https://fontstruct.com/gallery/tag/4373/Password

@hmalphettes
Copy link
Contributor Author

Hi everyone, I created a proof of concept for this feature: #6462

lodging-sensitive-credentials-in-the-vault-UI

@meirish that is how I stumbled on the auth-configuration regression in the UI #6465
Here is how it looks for the LDAP password when the obfuscated-input class is set on the auth-config form:

Screenshot 2019-03-30 at 6 10 00 AM

hmalphettes added a commit to hmalphettes/vault that referenced this issue Jun 22, 2019
hmalphettes added a commit to hmalphettes/vault that referenced this issue Jun 3, 2020
hmalphettes added a commit to hmalphettes/vault that referenced this issue Jun 3, 2020
@hmalphettes
Copy link
Contributor Author

Hi, I have squashed my changes on v1.4.2: hmalphettes@e773d01
and I'll continue to maintain this on my personal repository.

I hope this helps!

hmalphettes added a commit to hmalphettes/vault that referenced this issue Jul 6, 2020
hmalphettes added a commit to hmalphettes/vault that referenced this issue Sep 5, 2020
hmalphettes added a commit to hmalphettes/vault that referenced this issue Sep 6, 2020
@aphorise
Copy link
Contributor

aphorise commented Sep 2, 2022

@hmalphettes - hey thank you for your efforts on this back then. Can you confirm if it's okay to close this issue as these suggestions seem to have been applied.
Screenshot 2022-09-03 at 00 04 31
Screenshot 2022-09-03 at 00 08 12

@aphorise
Copy link
Contributor

aphorise commented Sep 7, 2022

Closing due to no response and issue being fixed already. Please re-open if I've mistaken.

@aphorise aphorise closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants