Move awsutil over to the go-secure-stdlib version #12128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the other libraries that were migrated, there are no usages of this lib in any of our plugins, and the only other known usage was in go-kms-wrapping, which has been updated. Aliasing it like the other libs would still keep the aws-sdk-go dep in the sdk module because of the function signatures. So I've simply removed it entirely here.
calvn
approved these changes
Jul 20, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
Unlike the other libraries that were migrated, there are no usages of this lib in any of our plugins, and the only other known usage was in go-kms-wrapping, which has been updated. Aliasing it like the other libs would still keep the aws-sdk-go dep in the sdk module because of the function signatures. So I've simply removed it entirely here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the other libraries that were migrated, there are no usages of
this lib in any of our plugins, and the only other known usage was in
go-kms-wrapping, which has been updated. Aliasing it like the other libs
would still keep the aws-sdk-go dep in the sdk module because of the
function signatures. So I've simply removed it entirely here.