Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/vault-k8s: update the service annotation #15965

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Jun 13, 2022

The injector's service annotation is really the vault address to
use, and not just the name of the service.

Also change a couple mentions of "controller" to "injector".

Related to hashicorp/vault-k8s#299

The injector's `service` annotation is really the vault address to
use, and not just the name of the service.

Also change a couple mentions of "controller" to "injector".
@shujun10086
Copy link
Contributor

Hi, if you can help me to add reviewer for my pull request ? No idea at all Thanks
#15946

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvoran tvoran merged commit 9566221 into main Jun 14, 2022
tvoran pushed a commit that referenced this pull request Jun 14, 2022
The injector's `service` annotation is really the vault address to
use, and not just the name of the service.

Also change a couple mentions of "controller" to "injector".
@tomhjp tomhjp deleted the docs/VAULT-6571/update-injector-service-annotation branch June 15, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants