Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

cli: Fix panic in config get #3039

Merged
merged 2 commits into from Feb 24, 2022
Merged

cli: Fix panic in config get #3039

merged 2 commits into from Feb 24, 2022

Conversation

xiaolin-ninja
Copy link
Contributor

Screen Shot 2022-02-23 at 12 53 03 PM

When running waypoint config get -app=<app> outside the project directory, Waypoint panics instead of returning a proper error.

Now it returns:

❯ waypoint-dev config get -app=example-java
please also define project with -project

@xiaolin-ninja xiaolin-ninja added pr/no-changelog No automatic changelog entry required for this pull request backport/0.7.x labels Feb 23, 2022
@github-actions github-actions bot added the core label Feb 23, 2022
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Backport too? edit: nevermind, already added!

I do think this could use a changelog though since it fixed a bug

@xiaolin-ninja xiaolin-ninja removed the pr/no-changelog No automatic changelog entry required for this pull request label Feb 23, 2022
@xiaolin-ninja xiaolin-ninja changed the title Fix panic in config get bug/cli: Fix panic in config get Feb 23, 2022
@xiaolin-ninja xiaolin-ninja changed the title bug/cli: Fix panic in config get cli: Fix panic in config get Feb 23, 2022
@xiaolin-ninja xiaolin-ninja merged commit 75c229c into main Feb 24, 2022
@xiaolin-ninja xiaolin-ninja deleted the bug/config_get_proj_ref branch February 24, 2022 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants