This repository was archived by the owner on Jan 8, 2024. It is now read-only.
feat(aws-lambda): support architecture
#3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiskevinwang
commented
Feb 17, 2022
|
|
||
| .PHONY: install | ||
| install: bin # build and copy binaries to $GOPATH/bin/waypoint | ||
| rm $(GOPATH)/bin/waypoint |
Contributor
Author
There was a problem hiding this comment.
rming the binary first fixed an error I was running into:
Λ $GOPATH/bin/waypoint docs
[1] 74270 killed $GOPATH/bin/waypoint docs
thiskevinwang
commented
Feb 17, 2022
| github.com/adrg/xdg v0.2.1 | ||
| github.com/armon/circbuf v0.0.0-20190214190532-5111143e8da2 | ||
| github.com/aws/aws-sdk-go v1.36.31 | ||
| github.com/aws/aws-sdk-go v1.43.0 |
Contributor
Author
There was a problem hiding this comment.
Lambda Architectures seemed to have been introduced in 1.41.0
thiskevinwang
force-pushed
the
kw/lambda-arm64
branch
from
64ec0d9 to
38ee485
Compare
thiskevinwang
force-pushed
the
kw/lambda-arm64
branch
from
7d2c486 to
3bb6665
Compare
briancain
approved these changes
Mar 1, 2022
Contributor
briancain
left a comment
briancain
left a comment
There was a problem hiding this comment.
I haven't tried this, but the code makes sense to me providing an option to set the architecture for a lambda 👍🏻
Co-authored-by: Brian Cain <bcain@hashicorp.com>
Co-authored-by: Brian Cain <bcain@hashicorp.com>
thiskevinwang
force-pushed
the
kw/lambda-arm64
branch
from
c89f0db to
749d1da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an optional
architecturefield (x86_64 | arm64) to aws-lambda to support setting architecture on lambda creation and update.Short term option for #3026