This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
e2e updates #3664
Merged
e2e updates #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krantzinator
added
pr/no-changelog
catsby
approved these changes
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the branch name; there was no bug with the tests -- they found a real bug!
But this does fix the fact that when it found the bug, we weren't seeing the error message from
stderr. Plus updating theCIenv var so that we don't see the spinner output|\-/|\-/|\-/|\-/---prefixing the test results.As these only run on main; see this run for the results of this PR.