Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

AWS App Runner builder+releaser #3941

Closed
wants to merge 22 commits into from
Closed

AWS App Runner builder+releaser #3941

wants to merge 22 commits into from

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Sep 28, 2022

Description

This introduces the aws-apprunner builder & release-manager components

example:

#...
  deploy {
    use "aws-apprunner" {
      name   =  "my-service-name"
      region = var.region
      port   = 8080
      static_environment = {
        "PORT" = "8080"
      }
    }
  }

  release {
    use "aws-apprunner" {
    }
  }
# ...

Screenshots

CleanShot 2023-01-30 at 20 04 52@2x

TODO

  • pass Waypoint Labels to App Runner Tags
  • waypoint exec will not be supported as you cannot shell into an app runner replica
  • static env vars get updated on subsequent waypoint up - 5b7a79d
  • document recommended -prune=false, similar to builtin/nomad/canary - 9e75fea

Fixes #1503

@thiskevinwang
Copy link
Contributor Author

@briancain @paladin-devops 👋 — do you have any guidance for making a component (platform, releaser, etc.) opt out of Waypoint's default pruning behavior?

I'd like to have only waypoint destroy invoke the Destroyer, and have waypoint up not prune older deployments/releases. AppRunner really only keeps track of 1 "service", so there's nothing to prune.

@briancain
Copy link
Member

@thiskevinwang - Unfortunately I don't think this is something that's configurable via a plugin. Pruning is handled at the job level and as far as I can think I don't know of a clean way for you to disable it automatically.

@paladin-devops
Copy link
Contributor

@thiskevinwang Brian is right. I faced something similar with the canary plugin for Nomad. In the documentation for the plugin, I advise users to use -prune=false for now though!

@thiskevinwang
Copy link
Contributor Author

@paladin-devops, ok, sounds good to me! (Though an accidental waypoint up without -prune=false seems very scary 😅 )

@briancain
Copy link
Member

@thiskevinwang @paladin-devops - since this has come up a couple of times with plugins, might be worth opening a feature request and we can figure out how to support something like configuring pruning via plugins!

@briancain
Copy link
Member

Hey there @thiskevinwang - what's the status on this PR? If there's still work to do, it might make sense to keep your branch active but close this PR to save you the trouble of fixing rebases while it goes stale.

@thiskevinwang
Copy link
Contributor Author

@briancain I'd say close this, unfortunately. 😢 🥲

As is, the functionality (waypoint up) in this PR works but I've never felt comfortable about... mostly in that it's too easy to auto-destroy your app (a single App Runner service) through Waypoint's default pruning behavior.

@thiskevinwang
Copy link
Contributor Author

it might make sense to keep your branch active but close this PR to save you the trouble of fixing rebases while it goes stale.

Closing PR this but I'll leave the branch! & FWIW, because this PR is mostly additive, rebases haven't been an issue :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS App Runner
4 participants