Hi! I cleaned up your code for you! #6

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
10 participants

Hi there!

This is WhitespaceBot. I'm an open-source robot that removes trailing white space in your code, and gives you a gitignore file if you didn't have one!

Why whitespace? Whitespace is an eyesore for developers who use text editors with dark themes. It's not a huge deal, but it's a bit annoying if you use Vim in a terminal. Really, I'm just a proof of concept - GitHub's V3 API allows robots to automatically improve open source projects, and that's really cool. Hopefully, somebody, maybe you!, will fork me and make me even more useful. My owner is funding a bounty to anybody who can add security fixing features to me.

I've only cleaned your most popular project, and I've added you to a list of users not to contact again, so you won't get any more pull requests from me unless you ask. If I'm misbehaving, please email my owner and tell him to turn me off! If this is pull request is of no use to you, please just ignore it.

Thanks!
WhiteSpacebot from Gun.io.

tpope closed this Dec 21, 2011

Awesome!!

That's really cool.

Collaborator

tpope commented Dec 21, 2011

I hope you guys are being sarcastic. Otherwise you should check out the
diff.

On Wednesday, December 21, 2011, NilGravitas <
reply@reply.github.com>
wrote:

That's really cool.


Reply to this email directly or view it on GitHub:
#6 (comment)

jdan commented Dec 21, 2011

Did anyone actually look at the commit? It does nothing but add a generic .gitignore. No whitespace removed whatsoever (in fact, the owner rejected the request). To me, this does nothing but advertise the author's website. Not a fan of this trend.

Did anyone actually look at the commit? It does nothing but add a generic .gitignore. No whitespace removed whatsoever (in fact, the owner rejected the request).

The developer might have gotten a logical condition wrong. It should be post if white space is wrong *AND* lacking ignore file not post if white space wrong *OR* lacking ignore file.

Just adding a ignore file doesn't make sense for a "WhitespaceBot".

To me, this does nothing but advertise the author's website. Not a fan of this trend.

I also agree with you about this. At least the advertisement should be minimal. (A single line and a link to the author's website?)

I also agree with you about this. At least the advertisement should be minimal. (A single line and a link to the author's website?)

What is this? There is one link to gun.io, which is never said to be the author's website (it is, yes, but it took me some looking around to find out). I do agree that it shouldn't just add a .gitignore though.

This is spammy. :/

I'm not particularly fond of this!

pboling commented Dec 21, 2011

It is a very cool tool. It just needs to be improved. I was not aware of the power of a github robot until I saw this tool a few weeks ago, and for that evangelism I think it is useful. Also is there a valid reason for not having a .gitignore in a git source repo? I've always added one to every repo I've forked that lacked one... because I didn't want my junk getting back into their repo. I am interested to know of an argument against adding a .gitignore to a git repo.

Collaborator

tpope commented Dec 21, 2011

The point of a project .gitignore is to ignore build files and other project artifacts. A dot files repo has neither. Files created by your editor or IDE belong in your personal excludes file.

So minus one point for giving a bullshit .gitignore at all, one point for slipping it into an unrelated whitespace commit, and one point for not including any whitespace in said whitespace commit.

3 POINTS FROM GRYFFINDOR

pboling commented Dec 22, 2011

@tpope: Thanks. I had forgotten to consider projects without artifacts or build files. :/ Still I think there must be something cool that can be done with a robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment