Fix the phantom header key bug.

Bug report: http://groups.google.com/group/rack-devel/browse_thread/thread/cb0548dfe7a70702.
hashrocket · Sep 22, 2010 · b937c01 · b937c01
1 parent 11e509b
commit b937c01
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -319,7 +319,7 @@ def to_hash
       end
 
       def [](k)
-        super(@names[k] ||= @names[k.downcase])
+        super(k) || super(@names[k.downcase])
       end
 
       def []=(k, v)

diff --git a/test/spec_utils.rb b/test/spec_utils.rb
@@ -309,6 +309,12 @@
     end
   end
 
+  should "not create headers out of thin air" do
+    h = Rack::Utils::HeaderHash.new
+    h['foo']
+    h['foo'].should.be.nil
+    h.should.not.include 'foo'
+  end
 end
 
 describe Rack::Utils::Context do