New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to readme for correct installation guidance #167

Merged
merged 1 commit into from Sep 17, 2017

Conversation

Projects
None yet
3 participants
@ckr123

ckr123 commented Sep 14, 2017

The package.json is located in the assets folder

Show outdated Hide outdated README.md
@tmock12

This comment has been minimized.

Show comment
Hide comment
@tmock12

tmock12 Sep 15, 2017

Member

Instead of changing directories, running npm install and then changing directories again, we can just run npm install --prefix assets

so:

$ cd assets
$ npm install
$ cd ..

becomes:

npm install --prefix assets
Member

tmock12 commented Sep 15, 2017

Instead of changing directories, running npm install and then changing directories again, we can just run npm install --prefix assets

so:

$ cd assets
$ npm install
$ cd ..

becomes:

npm install --prefix assets

@tmock12 tmock12 self-requested a review Sep 15, 2017

@tmock12

👍 from me @jwworth . Thanks @ckr123 ! Hope you enjoy using Tilex. If you run into any other issues or have feature requests please feel free to open PR's or issues.

@tmock12

This comment has been minimized.

Show comment
Hide comment
@tmock12

tmock12 Sep 15, 2017

Member

Actually @ckr123 instead of leaving all three commits, would you mind squashing them into one?

Member

tmock12 commented Sep 15, 2017

Actually @ckr123 instead of leaving all three commits, would you mind squashing them into one?

@jwworth

This comment has been minimized.

Show comment
Hide comment
@jwworth

jwworth Sep 15, 2017

Member

Nice input @tmock12, and thanks for the updates @ckr123. Please squash into one commit and we'll merge this in.

Member

jwworth commented Sep 15, 2017

Nice input @tmock12, and thanks for the updates @ckr123. Please squash into one commit and we'll merge this in.

Christoffer Frydkjær
Change to readme for correct installation guidance
change to a more readable change dir command

Oneline the npm installation process
@ckr123

This comment has been minimized.

Show comment
Hide comment
@ckr123

ckr123 Sep 17, 2017

Squashed the commits, glad i could help though it was a really small change. :)
And thank you for a nice product, looking forward to implementing it at work.

ckr123 commented Sep 17, 2017

Squashed the commits, glad i could help though it was a really small change. :)
And thank you for a nice product, looking forward to implementing it at work.

@jwworth jwworth merged commit 6e90c6c into hashrocket:master Sep 17, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jwworth

This comment has been minimized.

Show comment
Hide comment
@jwworth

jwworth Sep 17, 2017

Member

Thank you! 👍

Member

jwworth commented Sep 17, 2017

Thank you! 👍

@jwworth

This comment has been minimized.

Show comment
Hide comment
@jwworth

jwworth Sep 17, 2017

Member

Please contact us if you set up an instance and are able to share! Pull requests and issues always welcome.

Member

jwworth commented Sep 17, 2017

Please contact us if you set up an instance and are able to share! Pull requests and issues always welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment