New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format auth_controller.ex #189

Merged
merged 1 commit into from Oct 14, 2017

Conversation

Projects
None yet
3 participants
@jwworth
Member

jwworth commented Oct 13, 2017

This is the first in a series of pull request I plan to open, inspired by Elixir Issue #6643.

It's the result of running the Elixir formatter (shipping with Elixir 1.6) against one file in Tilex. Like the Elixir language, I'd like Tilex to conform to the Elixir formatter and growing style consensus of this community. A final step will be enforcing it on each CI build.

I realize this will create churn, but in my opinion it's worth it. These changes can start conversation about our code, and maybe some pull requests against the Elixir formatter itself.

If you're interested in joining in, install Elixir head (with homebrew for example):

$  brew install elixir --HEAD

And run the formatter on your file of choice:

$ mix format lib/tilex/path/to/my_file.ex

Elixir Issue #6643 explains how to use this tool in greater detail.

@hashrocketeer hashrocketeer temporarily deployed to tilex-staging-pr-189 Oct 13, 2017 Inactive

@jwworth

This comment has been minimized.

Show comment
Hide comment
@jwworth

jwworth Oct 13, 2017

Member

The big change here is adding parens to make it more obvious what the arguments to a function are. I like this more than 'poetry mode' most of the time.

The spacing changes make sense to me and I think are an improvement.

Member

jwworth commented Oct 13, 2017

The big change here is adding parens to make it more obvious what the arguments to a function are. I like this more than 'poetry mode' most of the time.

The spacing changes make sense to me and I think are an improvement.

@jwworth jwworth merged commit 576e555 into master Oct 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@jwworth jwworth deleted the format-lib/tilex_web/controllers/auth_controller.ex branch Oct 14, 2017

@sotojuan

This comment has been minimized.

Show comment
Hide comment
@sotojuan

sotojuan Oct 25, 2017

Definitely looks a lot better, thanks for the repo 👍

sotojuan commented Oct 25, 2017

Definitely looks a lot better, thanks for the repo 👍

@jwworth jwworth referenced this pull request Oct 25, 2017

Merged

Format the router #202

jwworth added a commit that referenced this pull request Oct 27, 2017

This was referenced Oct 27, 2017

@jwworth jwworth referenced this pull request Jan 26, 2018

Closed

Auto-format Tilex #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment