Skip to content

1606-enhancement-webui-agentstats-too-many-backend-requests #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

1606-enhancement-webui-agentstats-too-many-backend-requests #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8903b8
Fix: remove unnecessary backend calls from agent status component
Oct 7, 2025
e5858a4
Fix: remove unnecessary backend calls from agent status component
Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 1 addition & 88 deletions src/app/agents/agent-status/agent-status.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
import { Component, OnInit } from '@angular/core';

import { ASC } from '@src/app/core/_constants/agentsc.config';
import { PageTitle } from '@src/app/core/_decorators/autotitle';
import { JAgentStat } from '@src/app/core/_models/agent-stats.model';
import { JAgent } from '@src/app/core/_models/agent.model';
import { ResponseWrapper } from '@src/app/core/_models/response.model';
import { JsonAPISerializer } from '@src/app/core/_services/api/serializer-service';
import { SERV } from '@src/app/core/_services/main.config';
import { GlobalService } from '@src/app/core/_services/main.service';
import { RequestParamBuilder } from '@src/app/core/_services/params/builder-implementation.service';
import { CookieService } from '@src/app/core/_services/shared/cookies.service';
import { environment } from '@src/environments/environment';

@Component({
selector: 'app-agent-status',
Expand All @@ -20,93 +11,15 @@ import { environment } from '@src/environments/environment';
@PageTitle(['Agent Status'])
export class AgentStatusComponent implements OnInit {
pageTitle = 'Agents Status';
showagents: JAgent[] = [];
_filteresAgents: JAgent[] = [];
pageSize = 20;

// view menu
view: string | number = 0;

// Agents Stats
statDevice: JAgentStat[] = [];
statTemp: JAgentStat[] = [];
statCpu: JAgentStat[] = [];

private maxResults = environment.config.prodApiMaxResults;

constructor(
private cookieService: CookieService,
private gs: GlobalService,
private serializer: JsonAPISerializer
) {}

setView(value: string) {
this.cookieService.setCookie('asview', value, 365);
this.ngOnInit();
}
constructor(private cookieService: CookieService) {}

getView() {
return this.cookieService.getCookie('asview');
}

ngOnInit(): void {
this.view = this.getView() || 0;
this.getAgentsPage();
this.getAgentStats();
}

/**
* Fetch agents from server
*/
private getAgentsPage() {
const agentRequestParams = new RequestParamBuilder().setPageSize(this.pageSize).create();

this.gs.getAll(SERV.AGENTS, agentRequestParams).subscribe((agentResponse: ResponseWrapper) => {
this.showagents = this._filteresAgents = this.serializer.deserialize<JAgent[]>(agentResponse);
// TODO: Not sure how this code works and what it is supposed to achieve as it mixes objects of different types together
// const getAData = agents.map((mainObject) => {
// const matchObjectTask = assignments.find((assignment) => assignment.agentId === mainObject.id);
//
// if (matchObjectTask != undefined) {
// const obj: any = { ...mainObject, ...matchObjectTask };
// return obj;
// } else {
// const obj: any = { ...mainObject };
// return obj;
// }
// });
// const jointasks = getAData.map((mainObject) => {
// const matchObjectTask = tasks.find((e) => e.id === mainObject.taskId);
// if (matchObjectTask != undefined) {
// return { ...mainObject, ...matchObjectTask };
// } else {
// return { ...mainObject };
// }
// });
//
// this.showagents = this.filteredAgents = jointasks.map((mainObject) => {
// const matchObjectAgents = chunks.find((e) => e.agentId === mainObject.agentId);
//
// if (matchObjectAgents != undefined) {
// return { ...mainObject, ...matchObjectAgents };
// } else {
// return { ...mainObject };
// }
// });
});
}

/**
* Fetch agent stats from server
*/
getAgentStats() {
const params = new RequestParamBuilder().setPageSize(this.maxResults).create();
this.gs.getAll(SERV.AGENTS_STATS, params).subscribe((agentStatsResponse: ResponseWrapper) => {
const agentStats = this.serializer.deserialize<JAgentStat[]>(agentStatsResponse);
const tempDateFilter = agentStats.filter((agentStat) => agentStat.time > 10000000); // Temp
this.statTemp = tempDateFilter.filter((u) => u.statType == ASC.GPU_TEMP); // Temp
this.statDevice = tempDateFilter.filter((u) => u.statType == ASC.GPU_UTIL); // Temp
this.statCpu = tempDateFilter.filter((u) => u.statType == ASC.CPU_UTIL); // Temp
});
}
}
Loading