Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammar productions #10

Merged
merged 2 commits into from May 17, 2019
Merged

Fixed grammar productions #10

merged 2 commits into from May 17, 2019

Conversation

@vijayphoenix
Copy link
Collaborator

vijayphoenix commented May 17, 2019

  1. All the changes in the made in the grammar productions are according to the YAML Spec 1.2.
  2. These changes fix the errors in test cases like LINK and LINK
  3. These changes will not become a source for some other errors/problems. (See performance improvements below)

Performance on tests from Yaml-test-suite

Before

done -- passed: 312 (ev: 29, ev+json: 88, ev+json+yaml: 124, err: 71) / failed: 6 (err: 4, ev:2, json:0, yaml:0, ok:0)

After

done -- passed: 314 (ev: 31, ev+json: 88, ev+json+yaml: 124, err: 71) / failed: 4 (err: 4, ev:0, json:0, yaml:0, ok:0)
@hvr
hvr approved these changes May 17, 2019
@hvr hvr added the bug label May 17, 2019
These changes fix the error in https://matrix.yaml.io/details/2EBW.html
@vijayphoenix

This comment has been minimized.

Copy link
Collaborator Author

vijayphoenix commented May 17, 2019

  1. This change in the grammar production is made to correct errors like LINK
  2. YAML specs does not explicitly mention this constraint. (Not followed by an ns-char)
    However, this constraint is necessary to satisfy both Rule 126 and Rule 190.
    The similarity between rule 184 and rule 190 also shows the need for the constraint
  3. These changes will not become a source for some other errors/problems. (See performance improvements below)

Performance on tests from Yaml-test-suite

Before

done -- passed: 312 (ev: 29, ev+json: 88, ev+json+yaml: 124, err: 71) / failed: 6 (err: 4, ev:2, json:0, yaml:0, ok:0)

After

done -- passed: 315 (ev: 31, ev+json: 88, ev+json+yaml: 125, err: 71) / failed: 3 (err: 3, ev:0, json:0, yaml:0, ok:0)
@hvr hvr added this to Done in GSOC 2019 May 17, 2019
@vijayphoenix vijayphoenix changed the title Fixed Plain Style and flow mapping productions Fixed grammar productions May 17, 2019
@hvr hvr merged commit e3a40fc into haskell-hvr:0.2 May 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hvr

This comment has been minimized.

Copy link
Collaborator

hvr commented May 17, 2019

For the record, these fixes make the previously failing test-cases below pass

  • 2EBW
  • 4ABK
  • FRK4
@hvr hvr added this to the 0.1.2.0 milestone May 17, 2019
@hvr hvr added the yaml-test-suite label May 18, 2019
@vijayphoenix vijayphoenix self-assigned this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GSOC 2019
  
Done
2 participants
You can’t perform that action at this time.