記事の追加: regex-applicative: 内部DSLとしての正規表現（ブログ記事版） #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hexirp
reviewed
Oct 26, 2019
igrep
changed the title
Member
Author
|
こちら、この間のHaskell-jpもくもく会で、regex-applicativeとパーサーコンビネーターの違いについての例を気にしていた @lotz84 さん、レビューをお願いしたいです！ 🙏 |
Hexirp
reviewed
Nov 23, 2019
Contributor
Hexirp
left a comment
Hexirp
left a comment
There was a problem hiding this comment.
読み直した結果、気になった点がいくつかあったのでコメントしておきます。しかし、 regex-applicative は面白そうですね。
Member
Author
|
@Hexirp レビューありがとうございます。
|
Hexirp
approved these changes
Dec 30, 2019
Contributor
Hexirp
left a comment
Hexirp
left a comment
There was a problem hiding this comment.
一つだけ気になる点がありましたが、そこはそのままでも大丈夫だと思います。他に気になる点はありませんでした。
Member
Author
|
@Hexirp レビューありがとうございました！ 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.