Does it make sense to port 2.2.30 to GHC 7.4? #24

Closed
mgajda opened this Issue Feb 3, 2012 · 5 comments

Comments

Projects
None yet
2 participants

mgajda commented Feb 3, 2012

It seems that the old version in HP can be easily ported to latest GHC 7.4, in case maintainer wanted to release a 2.2.3.1 package. May be nice since for some strange reasons cabal defaults to OpenGL 2.2.3.0, if installed on vanilla GHC 7.4.1.

mgajda commented Feb 3, 2012

PATCH:
diff -r -u OpenGL-2.4.0.2.orig/Graphics/Rendering/OpenGL/GL/GLboolean.hs OpenGL-2.4.0.2/Graphics/Rendering/OpenGL/GL/GLboolean.hs
--- OpenGL-2.4.0.2.orig/Graphics/Rendering/OpenGL/GL/GLboolean.hs 2012-02-03 07:04:22.929471373 +0100
+++ OpenGL-2.4.0.2/Graphics/Rendering/OpenGL/GL/GLboolean.hs 2012-02-03 07:01:29.397467256 +0100
@@ -26,5 +26,5 @@
False -> gl_FALSE
True -> gl_TRUE

-unmarshalGLboolean :: Num a => a -> Bool
+unmarshalGLboolean :: (Eq a, Num a) => a -> Bool
unmarshalGLboolean = (/= fromIntegral gl_FALSE)

Owner

dagit commented Feb 3, 2012

If understand correctly you are asking if we can fix version 2.2.3.0 (which is in the HP) to compile on ghc 7.4.1?

I'd much rather see the HP upgrade to a recent version of the OpenGL binding, but no one on the HP has responded to my request for help getting the current version into the HP: http://www.mail-archive.com/haskell-platform@projects.haskell.org/msg01691.html

Then there is the issue of how do we release 2.2.3.1? As I understand it hackage won't accept that version number now because it's a step backwards from the current version number. If hackage will accept it, then yeah we can do that.

mgajda commented Feb 4, 2012

Dear Jason,

On 02/03/2012 02:29 PM, Jason Dagit wrote:

If understand correctly you are asking if we can fix version 2.2.3.0 (which is in the HP) to compile on ghc 7.4.1?

Yes, that would be most conservative update to support newly released
GHC 7.4.1 in Haskell Platform.

I'd much rather see the HP upgrade to a recent version of the OpenGL binding, but no one on the HP has responded to my request for help getting the current version into the HP: http://www.mail-archive.com/haskell-platform@projects.haskell.org/msg01691.html

I support your call, but at the same time feel pressure to have HP
working ASAP with new GHC.

Then there is the issue of how do we release 2.2.3.1? As I understand it hackage won't accept that version number now because it's a step backwards from the current version number. If hackage will accept it, then yeah we can do that.

I have just uploaded an older version of the package Octree-0.2.0.1
http://hackage.haskell.org/package/Octree-0.2.0.1, even though
Octree-0.2.1 has been previously released.

So it is accepted. In case of minor versions at least.

Best regards
Michal

Owner

dagit commented Feb 5, 2012

I believe this is fixed now: http://hackage.haskell.org/package/OpenGL-2.2.3.1

Thank you for reporting the issue.

dagit closed this Feb 5, 2012

mgajda commented Feb 8, 2012

Thanks a lot Jason!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment