New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client streaming + http redirect result into runtime exception #1091

Open
domenkozar opened this Issue Nov 28, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@domenkozar
Copy link
Contributor

domenkozar commented Nov 28, 2018

If an http endpoint returns a redirect (for example http -> https upgrade), streaming client errors out:

HasClient @StreamBody
CallStack (from HasCallStack):
  error, called at src/Servant/Client/Core/Internal/HasClient.hs:550:44 in servant-client-core-0.15-KKVc3oxuLh47HhicA3CWtB:Servant.Client.Core.Internal.HasClient                                                                                                                                                     

https://github.com/haskell-servant/servant/blob/master/servant-client-core/src/Servant/Client/Core/Internal/HasClient.hs#L550

@phadej

This comment has been minimized.

Copy link
Member

phadej commented Nov 28, 2018

@phadej

This comment has been minimized.

Copy link
Member

phadej commented Nov 28, 2018

I won't be able to look at this issue this week. But if someone can make a patch, then I'll happily review it. (and make the release after merge).

@domenkozar

This comment has been minimized.

Copy link
Contributor

domenkozar commented Nov 28, 2018

There's absolutely no hurry from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment