Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate NoContent before (not) rendering it. #1587

Merged
merged 3 commits into from May 4, 2022
Merged

Evaluate NoContent before (not) rendering it. #1587

merged 3 commits into from May 4, 2022

Conversation

NorfairKing
Copy link
Contributor

This way it shows up as covered in coverage reports,

Currently any return NoContent is marked at "not covered" in coverage reports because it is not evaluated.

@NorfairKing
Copy link
Contributor Author

Now with a test as well @arianvp :D

@NorfairKing
Copy link
Contributor Author

I figured I'd also make a success-case test while I'm at it.

@NorfairKing NorfairKing changed the title Evaluate NoContent before rendering it. Evaluate NoContent before (not) rendering it. May 2, 2022
@NorfairKing
Copy link
Contributor Author

coverage
Here's an example of the missing coverage that I'm trying to fix.

@NorfairKing
Copy link
Contributor Author

Is there anything else that needs to happen before this can be merged?

@tchoutri
Copy link
Contributor

tchoutri commented May 4, 2022

Nope, I just waited for the CI to pass and then got sidetracked. Let's merge this!

@tchoutri tchoutri merged commit 036102a into haskell-servant:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchoutri tchoutri tchoutri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NorfairKing @tchoutri