-
-
Notifications
You must be signed in to change notification settings - Fork 416
Add hoistServer to HasServer #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like it. It's a bit of a shame that we'd have to define something identical for Client if we wanted to be able to operate on clients like this. Also, would we remove Enter
altogether, with this? Maybe over the course of a few major releases, to give users some time to port their code. It might be nice to have a blog post for the first release that'll ship with this patch, to clearly and loudly document this breaking change.
I'd only deprecate |
@alpmestan, should I rewrite whole |
dc5a220
to
16626f7
Compare
@phadej Well, we definitely want to explain the new stuffs. And maybe indeed add a little sentence or two that says "it replaces |
16626f7
to
4125b08
Compare
4125b08
to
24af338
Compare
982963f
to
822b853
Compare
@alpmestan I'll merge this now and update tutorial in separate PR (as I guess there will be much more to review). |
@phadej very good idea :) |
This is a refinement of an idea by @paf31.
I'll do documentation pass and add tests, if the idea is OK.