Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hoistServer to HasServer #804

Merged
merged 2 commits into from Sep 14, 2017
Merged

Add hoistServer to HasServer #804

merged 2 commits into from Sep 14, 2017

Conversation

@phadej
Copy link
Member

phadej commented Sep 8, 2017

This is a refinement of an idea by @paf31.

I'll do documentation pass and add tests, if the idea is OK.

@phadej phadej requested review from alpmestan and jkarni Sep 8, 2017
@phadej phadej added the in progress label Sep 8, 2017
@phadej phadej added this to the 0.12 milestone Sep 8, 2017
Copy link
Contributor

alpmestan left a comment

I quite like it. It's a bit of a shame that we'd have to define something identical for Client if we wanted to be able to operate on clients like this. Also, would we remove Enter altogether, with this? Maybe over the course of a few major releases, to give users some time to port their code. It might be nice to have a blog post for the first release that'll ship with this patch, to clearly and loudly document this breaking change.

@phadej

This comment has been minimized.

Copy link
Member Author

phadej commented Sep 8, 2017

I'd only deprecate enter, and keep it around for few major releases

@phadej

This comment has been minimized.

Copy link
Member Author

phadej commented Sep 14, 2017

@alpmestan, should I rewrite whole Enter section in the tutorial (i.e. only mention it existed?)

@phadej phadej force-pushed the phadej:hoist-server branch from dc5a220 to 16626f7 Sep 14, 2017
@alpmestan

This comment has been minimized.

Copy link
Contributor

alpmestan commented Sep 14, 2017

@phadej Well, we definitely want to explain the new stuffs. And maybe indeed add a little sentence or two that says "it replaces Enter, just do this to port your enter-based code over to hoistServer" ?

@phadej phadej force-pushed the phadej:hoist-server branch from 16626f7 to 4125b08 Sep 14, 2017
@phadej phadej force-pushed the phadej:hoist-server branch from 4125b08 to 24af338 Sep 14, 2017
@phadej phadej force-pushed the phadej:hoist-server branch from 982963f to 822b853 Sep 14, 2017
@phadej

This comment has been minimized.

Copy link
Member Author

phadej commented Sep 14, 2017

@alpmestan I'll merge this now and update tutorial in separate PR (as I guess there will be much more to review).

@phadej phadej merged commit 97aa7db into haskell-servant:master Sep 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phadej phadej deleted the phadej:hoist-server branch Sep 14, 2017
@alpmestan

This comment has been minimized.

Copy link
Contributor

alpmestan commented Sep 14, 2017

@phadej very good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.