Add Servant.Client.Free #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
commented
Mar 11, 2018
| @@ -48,3 +51,12 @@ decodedAs response contentType = do | |||
| Right val -> return val | |||
| where | |||
| accept = toList $ contentTypes contentType | |||
|
|
|||
| instance ClientF ~ f => RunClient (Free f) where | |||
There was a problem hiding this comment.
dunno if should rather have RunClientF f => RunClient (Free f)
phadej
commented
Mar 11, 2018
| runRequest req = liftF (RunRequest req id) | ||
| streamingRequest req = liftF (StreamingRequest req id) | ||
| throwServantError = liftF . Throw | ||
| catchServantError x h = go x where |
There was a problem hiding this comment.
this is not particularly correct, as RunRequest could throw things catchable by catchServantError too.
|
Is this missing a file ( |
|
oops |
jkarni
reviewed
Mar 11, 2018
| data ClientF a | ||
| = RunRequest Request (Response -> a) | ||
| | StreamingRequest Request (StreamingResponse -> a) | ||
| | Throw ServantError |
There was a problem hiding this comment.
Maybe adding a Catch constructor would help fix the problem with catchServantError that you mention below?
There was a problem hiding this comment.
catch isn't an algebraic effect. So it won't really work out well.
|
@jkarni @alpmestan I'd rather remove |
|
+1 to removing it. On my phone so can't review more carefully, but I think
that was my only concern.
…On Sunday, March 11, 2018, Oleg Grenrus ***@***.***> wrote:
@jkarni <https://github.com/jkarni> @alpmestan
<https://github.com/alpmestan> I'd rather remove catchServantError, we
don't use it itself, and I doubt anyone else
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#920 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABlKmnX93TAvSVm-jUE-AbbTY5cWkYgeks5tdUZCgaJpZM4SlqeL>
.
|
|
LGTM, and I don't mind the removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is useful in testing, it nothing else.