-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recipe introducing servant-pagination #946
Conversation
@KtorZ Haven't yet looked at the explanations (I won't be too picky though, don't worry), but is there a reason why your patch comes with both a See 5ac6de8 for an example of commit that adds a cookbook recipe with the code and explanations in a single file. The trick is to have:
in the .cabal file. This processes the file with markdown-unlit (which strips away all the markdown, only leaving the code) before giving its contents to GHC. |
Ah! You're entirely right, I wrongly committed that. I'll update 👍 |
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for taking the time to write it all down!
#### Parsing Options | ||
|
||
By default, `servant-pagination` provides an implementation of `getRangeOptions` for each | ||
`HasPagination` type-class. However, this can be overwritten when defining a instance of that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for each HasPagination
instance, I suppose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!
hide in shame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 93838ae
Thanks @KtorZ! Your recipe should appear on https://haskell-servant.readthedocs.io/en/latest/cookbook/index.html (note the |
Awesome! 🎉 |
@KtorZ the pagination library is missing a bunch of dependency bound updates, are you still maintaining this? I think it would be best if either the repo became part of this org, or that we removed it. |
Chiming in as one of the Chordify people with open source responsibility. :) If the dependency bounds can be fixed purely via a Hackage revision then @swamp-agr should be able to do that; if not I'd be happy to review a patch. In general I expect we'll maintain it just to the degree that we need for internal use - we're open to PRs of course but I've noticed that reviewing those tends to drift down to the bottom of my todo list. So with that in mind I wouldn't mind at all to transfer the repo to this org (but removing the cookbook instead is also fine by me). |
@isomorpheme Please review the linked patch, it seems like swamp-agr is not available. |
As proposed in #125, here's a short introduction to servant-pagination.
Feedback is welcome :)