Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servant-client: update README.md and test it #948

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@domenkozar
Copy link
Contributor

commented Apr 18, 2018

README.md was outdated, so I've brought it up in sync with the codebase and made sure it won't happen again.

I've tried to keep example in sync with http://haskell-servant.readthedocs.io/en/stable/tutorial/Client.html but with some simplification so that it's closer to a hello world.

@domenkozar domenkozar force-pushed the domenkozar:servant-client-readme branch from cee58af to 4996969 Apr 18, 2018

@alpmestan

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2018

Oh, does that work? Interesting! It does break on CI though, but I suspect this is because you're not listing markdown-unlit under build-tool-depends... isn't it?

EDIT: looks like you fixed it.

@domenkozar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2018

Seems to work now.

@alpmestan

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2018

@phadej Looks good to you?

@phadej phadej merged commit 63253f0 into haskell-servant:master Apr 20, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.