Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servant-client: update README.md and test it #948

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

domenkozar
Copy link
Contributor

@domenkozar domenkozar commented Apr 18, 2018

README.md was outdated, so I've brought it up in sync with the codebase and made sure it won't happen again.

I've tried to keep example in sync with http://haskell-servant.readthedocs.io/en/stable/tutorial/Client.html but with some simplification so that it's closer to a hello world.

@domenkozar domenkozar force-pushed the servant-client-readme branch from cee58af to 4996969 Compare April 18, 2018 13:18
@alpmestan
Copy link
Contributor

alpmestan commented Apr 18, 2018

Oh, does that work? Interesting! It does break on CI though, but I suspect this is because you're not listing markdown-unlit under build-tool-depends... isn't it?

EDIT: looks like you fixed it.

@domenkozar
Copy link
Contributor Author

Seems to work now.

@alpmestan
Copy link
Contributor

@phadej Looks good to you?

@phadej phadej merged commit 63253f0 into haskell-servant:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants