Merged
Conversation
This was missed due to an oversight.
alpmestan
approved these changes
Jun 10, 2018
Contributor
alpmestan
left a comment
alpmestan
left a comment
There was a problem hiding this comment.
LGTM, and the tests pass. All good!
Contributor
Author
|
Thanks! I can't push "merge". |
Contributor
|
I was just waiting for the green CI (one of the CI scenarios errored out because of the "no output in 10 mins" rule, I wanted to make sure that one was fine as well). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed due to an oversight.
Adding an explicit export list to
ServantSpec.hswould allow a computer to catch these problems. I haven't done that here.