Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run captureAllSpec #975

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Conversation

jml
Copy link
Contributor

@jml jml commented Jun 10, 2018

This was missed due to an oversight.

Adding an explicit export list to ServantSpec.hs would allow a computer to catch these problems. I haven't done that here.

This was missed due to an oversight.
Copy link
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the tests pass. All good!

@jml
Copy link
Contributor Author

jml commented Jun 10, 2018

Thanks! I can't push "merge".

@alpmestan alpmestan merged commit 774a9f4 into haskell-servant:master Jun 10, 2018
@alpmestan
Copy link
Contributor

alpmestan commented Jun 10, 2018

I was just waiting for the green CI (one of the CI scenarios errored out because of the "no output in 10 mins" rule, I wanted to make sure that one was fine as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants