Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run `captureAllSpec` #975

Merged
merged 1 commit into from Jun 10, 2018

Conversation

Projects
None yet
2 participants
@jml
Copy link
Contributor

commented Jun 10, 2018

This was missed due to an oversight.

Adding an explicit export list to ServantSpec.hs would allow a computer to catch these problems. I haven't done that here.

Run `captureAllSpec`
This was missed due to an oversight.
@alpmestan
Copy link
Contributor

left a comment

LGTM, and the tests pass. All good!

@jml

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2018

Thanks! I can't push "merge".

@alpmestan alpmestan merged commit 774a9f4 into haskell-servant:master Jun 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alpmestan

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2018

I was just waiting for the green CI (one of the CI scenarios errored out because of the "no output in 10 mins" rule, I wanted to make sure that one was fine as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.