Hlint suggestions #260
Merged
Hlint suggestions #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have rebased this PR onto master. |
ocheron
approved these changes
Dec 17, 2017
| @@ -314,7 +311,7 @@ onServerHello ctx cparams sentExts (ServerHello rver serverRan serverSession cip | |||
|
|
|||
| -- intersect sent extensions in client and the received extensions from server. | |||
| -- if server returns extensions that we didn't request, fail. | |||
| when (not $ null $ filter (not . flip elem sentExts . (\(ExtensionRaw i _) -> i)) exts) $ | |||
| unless (null $ filter (not . flip elem sentExts . (\(ExtensionRaw i _) -> i)) exts) $ | |||
There was a problem hiding this comment.
Can't this be further simplified with all?
There was a problem hiding this comment.
Yes, we can. But I don't know whether or not @vincenthz likes it.
There was a problem hiding this comment.
I'm not a fan of when not -> unless, it's much less readable IMHO, but if you guys are happy with those changes, let's move forward. same goes for all. I either will adapt myself to the syntax or go mad :)
There was a problem hiding this comment.
Let's keep this as is.
|
Merged. Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accepts reasonable hlint suggestions.