Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Tests and Benchmarks for Float and Double Builders #638

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

BebeSparkelSparkel
Copy link
Contributor

@BebeSparkelSparkel BebeSparkelSparkel commented Jan 15, 2024

Tests fail from an existing bug detailed in #641

bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
@BebeSparkelSparkel
Copy link
Contributor Author

@clyring I have made some changes and comments since your last review.

@clyring
Copy link
Member

clyring commented May 16, 2024

Thanks for the ping. Sorry for being so slow on this round of review--I will take another look this weekend.

bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
tests/builder/Data/ByteString/Builder/Tests.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
bench/BenchAll.hs Outdated Show resolved Hide resolved
tests/builder/Data/ByteString/Builder/Tests.hs Outdated Show resolved Hide resolved
bytestring.cabal Show resolved Hide resolved
@BebeSparkelSparkel
Copy link
Contributor Author

I do not understand the build error for ppc64le

@Bodigrim
Copy link
Contributor

@BebeSparkelSparkel you probably need to extend this line:

apt-get install -y curl ghc libghc-tasty-quickcheck-dev libghc-syb-dev

@BebeSparkelSparkel
Copy link
Contributor Author

That fixed it!

BebeSparkelSparkel and others added 14 commits July 22, 2024 10:06
Co-authored-by: Matthew Craven <clyring@gmail.com>
Co-authored-by: Matthew Craven <clyring@gmail.com>
Co-authored-by: Matthew Craven <clyring@gmail.com>
using non base casting functions
floating point data does not depend on intData
better generation of specials
fixed DoubleSmall bench using the wrong test data
Co-authored-by: Matthew Craven <clyring@gmail.com>
@BebeSparkelSparkel
Copy link
Contributor Author

@clyring rebased and solved conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants