diff --git a/cabal-install/Distribution/Client/ProjectBuilding.hs b/cabal-install/Distribution/Client/ProjectBuilding.hs index f575787ea67..d1620ecc7c4 100644 --- a/cabal-install/Distribution/Client/ProjectBuilding.hs +++ b/cabal-install/Distribution/Client/ProjectBuilding.hs @@ -1051,8 +1051,8 @@ buildAndInstallUnpackedPackage verbosity isParallelBuild = buildSettingNumJobs >= 2 whenHaddock action - | hasValidHaddockTargets = action - | otherwise = return () + | hasValidHaddockTargets pkg = action + | otherwise = return () configureCommand = Cabal.configureCommand defaultProgramDb configureFlags v = flip filterConfigureFlags v $ @@ -1299,8 +1299,8 @@ buildInplaceUnpackedPackage verbosity | otherwise = action whenHaddock action - | hasValidHaddockTargets = action - | otherwise = return () + | hasValidHaddockTargets pkg = action + | otherwise = return () whenReRegister action = case buildStatus of diff --git a/cabal-install/Distribution/Client/ProjectOrchestration.hs b/cabal-install/Distribution/Client/ProjectOrchestration.hs index 5e56778ca49..6e772eda4df 100644 --- a/cabal-install/Distribution/Client/ProjectOrchestration.hs +++ b/cabal-install/Distribution/Client/ProjectOrchestration.hs @@ -140,8 +140,7 @@ import Distribution.Simple.Command (commandShowOptions) import Distribution.Simple.Configure (computeEffectiveProfiling) import Distribution.Simple.Utils - ( die' - , notice, noticeNoWrap, debugNoWrap ) + ( die', warn, notice, noticeNoWrap, debugNoWrap ) import Distribution.Verbosity import Distribution.Text import Distribution.Simple.Compiler @@ -940,7 +939,7 @@ dieOnBuildFailures verbosity plan buildOutcomes -- For all failures, print either a short summary (if we showed the -- build log) or all details - fail' verbosity $ unlines + dieIfNotHaddockFailure verbosity $ unlines [ case failureClassification of ShowBuildSummaryAndLog reason _ | verbosity > normal @@ -969,7 +968,7 @@ dieOnBuildFailures verbosity plan buildOutcomes maybeToList (InstallPlan.lookup plan pkgid) ] - fail' + dieIfNotHaddockFailure | all isHaddockFailure failuresClassification = warn | otherwise = die' where