Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

sdist and clean should never be given Maybe LocalBuildInfo #126

Closed
bos opened this Issue · 4 comments

2 participants

Bryan O'Sullivan Johan Tibell
Bryan O'Sullivan
Owner

(Imported from Trac #133, reported by guest on 2007-05-26)

Currently cleanHook, postClean, sDistHook, postSDist get a Maybe LocalBuildInfo? argument. They shouldn't do something different depending on, e.g., what compiler they have been configured with, so they should not be passed this.

If they /need/ something from LocalBuildInfo? (e.g. happy in order to generate files to put in the source tarball?) then they should /always/ be passed something (either LocalBuildInfo? or a smaller datatype).

Bryan O'Sullivan
Owner

(Imported comment by @dcoutts on 2007-05-26)

See also bug #134

Bryan O'Sullivan
Owner

(Imported comment by @dcoutts on 2007-09-17)

sdist needs to find pre-processors. That requires the ProgramConfiguration which we get during the configure step. We could use the defaultProgramConfiguration but then we will fail if we need any non-standard programs.

clean does not need the LocalBuildInfo at all. The current code uses it but it's not justified.

Bryan O'Sullivan
Owner

(Imported comment by @dcoutts on 2008-01-21)

Half done.

Thu Jun  4 21:38:30 BST 2009  Duncan Coutts <duncan@haskell.org>
  * Do not pass Maybe LocalBuildInfo to clean hook
  It is a bad idea for clean to do anything different depending
  on whether the package was configured already or not. The
  actual cleaning code did not use the LocalBuildInfo so this
  only changes in the UserHooks interface. No Setup.hs scripts
  actually make of this parameter for the clean hook.
  Part of ticket #133.
Johan Tibell
Owner

Closing as there's been no activity in years.

We're cleaning up the bug tracker to make it useful again and are thus closing bugs that haven't seen any activity in a long time. Please re-open (or file a new bug) if the problem reappears.

Johan Tibell tibbe closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.