Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Drop Haddock 0.x support #1718

Open
Fuuzetsu opened this Issue · 0 comments

1 participant

@Fuuzetsu

Module comment in Cabal.Distribution.Simple.Haddock says that the module supports 0.x and 2.x Haddock versions. Perhaps it'd be a good idea to drop 0.x support to simplify the module.

I doubt that there's a compiler version that compiles today's Cabal and Haddock 0.x and I doubt anyone still uses Haddock 0.x and expects modern tools interacting with it to work.

@iainnicol iainnicol referenced this issue from a commit in iainnicol/cabal
@iainnicol iainnicol Remove support for Haddock versions < 2.0
This will allow code to be simplified.  Currently we preprocess both
Literate Haskell files and Haskell files requiring the CPP, but newer
versions of Haddock can handle these natively.

Fixes issue #1718.
5b5b741
@iainnicol iainnicol referenced this issue from a commit in iainnicol/cabal
@iainnicol iainnicol Remove support for Haddock versions < 2.0
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue #1718.
98c537f
@mzero mzero referenced this issue from a commit in mzero/cabal
@iainnicol iainnicol Remove support for Haddock versions < 2.0
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue #1718.

Conflicts:
	Cabal/Distribution/Simple/Haddock.hs
	Cabal/Distribution/Simple/PreProcess.hs
	Cabal/Distribution/Simple/Setup.hs
b1957de
@tibbe tibbe referenced this issue from a commit
@iainnicol iainnicol Remove support for Haddock versions < 2.0
Dropping this support is unlikely to be a problem in practice.  Debian
oldstable is currently on version 2.6.0 of Haddock, for example.

This change enables future code simplification.  Currently we
preprocess both Haskell files requiring the CPP and Literate Haskell
files; newer versions of Haddock can handle these natively.

Fixes issue #1718.

(cherry picked from commit 98c537f)
e945945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.