Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

cabal-install needs new http download component #441

Open
bos opened this Issue May 24, 2012 · 1 comment

Comments

Projects
None yet
1 participant
Contributor

bos commented May 24, 2012

(Imported from Trac #448, reported by @dcoutts on 2009-01-10)

The way in which cabal-install currently uses the HTTP library API is quite sub-optimal. It starts a new Broswer session for each connection. This means that it cannot take advantage of HTTP pipelining, connection pooling and other goodies.

One design would involve making some HTTP download object and making requests through that. The download object would start a thread to make the actual requests. Requests would be serialised, eg using a Chan. It probably wants to work by directing URLS be downloaded to local files. On top of this we should build some caching mechanism so that we can check for example if our package index is up to date before downloading the whole thing. It would also be nice to check the length and md5 header to catch short or corrupted downloads.

Something like:

downloader :: Settings -> IO Downloader
download :: Downloader -> URL -> FilePath -> IO ()
The download function is given the URL and the local file path. If the local file exists it is taken to be the cached file. It should download the URL to a temp file in the target directory and if all successful it should atomically rename it over the target file.

Perhaps error handling needs to be more explicit than just using IOErrors.

Contributor

bos commented May 24, 2012

(Imported comment by @dcoutts on 2009-01-10)

Also needs to properly report http errors to the end user. See #545 about downloads and #549 about uploads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment