Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal-install: cannot depend on public sublibrary when the package does not contain a main library too #6038

Closed
fgaz opened this issue May 7, 2019 · 3 comments
Closed

cabal-install: cannot depend on public sublibrary when the package does not contain a main library too #6038

fgaz opened this issue May 7, 2019 · 3 comments
Labels
cabal-install: solver type: bug

Comments

@fgaz
Copy link
Member

fgaz commented May 7, 2019 •
edited

Repro:

cabal.project:

packages: d, p

d.cabal:

cabal-version: 3.0
name: d
version: 0.1.0.0

library sublib
  visibility: public
  default-language: Haskell2010

p.cabal:

cabal-version: 3.0
name: p
version: 0.1.0.0

library
  build-depends: d:sublib
  default-language: Haskell2010

cabal v2-build p output:

cabal: Could not resolve dependencies:
[__0] trying: d-0.1.0.0 (user goal)
[__1] next goal: p (user goal)
[__1] rejecting: p-0.1.0.0 (requires library from d, but the component does
not exist)
[__1] fail (backjumping, conflict set: d, p)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: d, p

Adding an empty main library to d fixes it.:w
@fgaz fgaz mentioned this issue May 7, 2019
Open
@23Skidoo
Copy link
Member

23Skidoo commented May 7, 2019

Why not just prohibit such packages?

@23Skidoo
Copy link
Member

23Skidoo commented May 7, 2019

(At least for now, the restriction could be relaxed in a later spec version)

@fgaz
Copy link
Member Author

fgaz commented May 7, 2019

Good idea! It should be an easy to implement stopgap

grayjay added a commit to grayjay/cabal that referenced this issue May 13, 2019
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
ffaf323 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.  It also starts adding support for
library visibility, though it currently only works for source packages.  There
is a TODO for handling installed packages.

Fixes haskell#6038.
@grayjay grayjay mentioned this issue May 13, 2019
Closed
4 tasks
grayjay added a commit to grayjay/cabal that referenced this issue Nov 21, 2019
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
9017952 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
@grayjay grayjay self-assigned this Nov 22, 2019
grayjay added a commit to grayjay/cabal that referenced this issue Dec 17, 2019
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
3ce10aa 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Jan 20, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
3e8ddf7 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Jan 21, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
cfb57fc 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Jan 25, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
b05d3b2 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Feb 1, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
d59d2b4 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Feb 16, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
bad2208 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Mar 1, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
2dff7ca 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Mar 23, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
bb09dbc 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Apr 6, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
703de47 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue Apr 18, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
a4e16b7 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
@fgaz fgaz mentioned this issue May 6, 2020
Open
31 tasks
grayjay added a commit to grayjay/cabal that referenced this issue May 9, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
93348de 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
grayjay added a commit to grayjay/cabal that referenced this issue May 17, 2020
@grayjay
Solver: Support dependencies on sub-libraries (issue haskell#6039).
a3dbcac 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
phadej pushed a commit to phadej/cabal that referenced this issue May 18, 2020
@grayjay @phadej
Solver: Support dependencies on sub-libraries (issue haskell#6039).
aa6bcf8 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
phadej pushed a commit to phadej/cabal that referenced this issue May 20, 2020
@grayjay @phadej
Solver: Support dependencies on sub-libraries (issue haskell#6039).
1fada6e 
This commit tracks dependencies on sub-libraries by extending the functionality
for tracking executables that was added in
e86f838.

It also starts adding support for library visibility, though it currently only
works for source packages.  There is a TODO for handling installed packages.

This commit handles visibility similarly to the way that the buildable field is
handled currently.  It only checks whether a component is made private by the
current environment and flag constraints at the start of dependency solving.
This means that the solver can treat a component as visible when the visibility
is controlled by an automatic flag, and the build can fail later, depending on
the value that is chosen for the flag.

Fixes haskell#6038.
@fgaz fgaz closed this as completed in a73fa07 May 23, 2020
phadej added a commit to phadej/cabal that referenced this issue May 24, 2020
@phadej
Add test for haskell#6038
18aa52b
phadej added a commit that referenced this issue May 26, 2020
@phadej
Merge pull request #6842 from phadej/test-6038
343b524 
Add test for #6038
@fgaz fgaz mentioned this issue May 1, 2021
Open
@fgaz fgaz mentioned this issue Apr 14, 2022
Open
@mpilgrem mpilgrem mentioned this issue Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: solver type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solver: Support dependencies on sub-libraries (issue #6039). grayjay/cabal
3 participants
@23Skidoo @grayjay @fgaz