Skip to content

dist checks defined on GenericPackageDescription are inert #652

Open
bos opened this Issue May 24, 2012 · 2 comments

2 participants

@bos
Haskell member
bos commented May 24, 2012

(Imported from Trac #660, reported by @kmcallister on 2010-04-11)

Some checks in Distribution.PackageDescription.Check are defined on GenericPackageDescription and are called via checkPackage. checkPackage is called by configure, which ignores dist-related checks, but not by sdist, which only calls checkConfiguredPackage.

So any dist-related checks on GenericPackageDescription, e.g. warning of base version not bounded above, will have no effect.

@bos
Haskell member
bos commented May 24, 2012

(Imported comment by @kmcallister on 2010-04-11)

Should revisit #395 when this is fixed.

@bos
Haskell member
bos commented May 24, 2012

(Imported comment by @dcoutts on 2010-04-11)

This will involve changing the public UserHooks API since the sDistHook uses PackageDescription rather than GenericPackageDescription.

@ttuegel ttuegel added this to the _|_ milestone Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.