cabal-install: Adapt for GHC 7.6 #1003

Merged
merged 1 commit into from Sep 8, 2012

Conversation

Projects
None yet
3 participants
@sol
Member

sol commented Aug 14, 2012

No description provided.

@sol

This comment has been minimized.

Show comment Hide comment
@sol

sol Aug 14, 2012

Member

The type of System.Directory.getModificationTime changed with directory-1.1.1.0. I did not make any effort to support older versions of directory, yet.

Questions:

  • Do we want to support older versions of directory?
  • Should parts of this go to master first?
Member

sol commented Aug 14, 2012

The type of System.Directory.getModificationTime changed with directory-1.1.1.0. I did not make any effort to support older versions of directory, yet.

Questions:

  • Do we want to support older versions of directory?
  • Should parts of this go to master first?
@tibbe

This comment has been minimized.

Show comment Hide comment
@tibbe

tibbe Aug 14, 2012

Member
  • Do we want to support older versions of directory?

Yes.

  • Should parts of this go to master first?

If this should go into the 1.16 release (I think it should) then this should go in the cabal-1.16 branch. I can merge it from that branch into master once committed.

Member

tibbe commented Aug 14, 2012

  • Do we want to support older versions of directory?

Yes.

  • Should parts of this go to master first?

If this should go into the 1.16 release (I think it should) then this should go in the cabal-1.16 branch. I can merge it from that branch into master once committed.

@sol

This comment has been minimized.

Show comment Hide comment
@sol

sol Aug 14, 2012

Member

@tibbe Ok, I update the change set. It may still be a good idea to wait for a reply on GHC #7144 before merging this.

Member

sol commented Aug 14, 2012

@tibbe Ok, I update the change set. It may still be a good idea to wait for a reply on GHC #7144 before merging this.

@tibbe

This comment has been minimized.

Show comment Hide comment
@tibbe

tibbe Aug 14, 2012

Member

The lower bound should be the first release of the package that actually includes the new API.

Member

tibbe commented Aug 14, 2012

The lower bound should be the first release of the package that actually includes the new API.

@23Skidoo

This comment has been minimized.

Show comment Hide comment
@23Skidoo

23Skidoo Aug 14, 2012

Member

Rather than adding #ifdefs to the client code, maybe it's better to introduce a Distribution.Compat.Directory module that abstracts over the interface differences? This is how we support old exceptions.

Member

23Skidoo commented Aug 14, 2012

Rather than adding #ifdefs to the client code, maybe it's better to introduce a Distribution.Compat.Directory module that abstracts over the interface differences? This is how we support old exceptions.

@tibbe

This comment has been minimized.

Show comment Hide comment
@tibbe

tibbe Aug 14, 2012

Member

@23Skidoo That sounds like a good idea, if doable.

Member

tibbe commented Aug 14, 2012

@23Skidoo That sounds like a good idea, if doable.

@sol

This comment has been minimized.

Show comment Hide comment
@sol

sol Aug 15, 2012

Member

@23Skidoo I agree that the current solution is not that nice. But if I understand correctly, Cabal does not depend on directory yet (at least not, if you build against base4).

Maybe just add a Compat module to cabal-install itself? This would not only keep the dependencies of Cabal to a minimum, but also increase code locality.

Member

sol commented Aug 15, 2012

@23Skidoo I agree that the current solution is not that nice. But if I understand correctly, Cabal does not depend on directory yet (at least not, if you build against base4).

Maybe just add a Compat module to cabal-install itself? This would not only keep the dependencies of Cabal to a minimum, but also increase code locality.

@23Skidoo

This comment has been minimized.

Show comment Hide comment
@23Skidoo

23Skidoo Aug 15, 2012

Member

@sol If the Cabal lib does not depend on directory, then I agree that cabal-install is the right place for the Compat module. In fact, cabal-install already has some Compat modules (cabal-install/Distribution/Compat).

Member

23Skidoo commented Aug 15, 2012

@sol If the Cabal lib does not depend on directory, then I agree that cabal-install is the right place for the Compat module. In fact, cabal-install already has some Compat modules (cabal-install/Distribution/Compat).

@sol

This comment has been minimized.

Show comment Hide comment
@sol

sol Sep 8, 2012

Member

@23Skidoo I now created a module Distribution.Compat.Time, which contains the #ifdefs.

Can somebody apply this and release a new version to Hackage?

Member

sol commented Sep 8, 2012

@23Skidoo I now created a module Distribution.Compat.Time, which contains the #ifdefs.

Can somebody apply this and release a new version to Hackage?

@tibbe tibbe merged commit d9d3382 into haskell:cabal-1.16 Sep 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment