Partial Fix for #543 #1015

Merged
merged 2 commits into from Oct 29, 2012

Conversation

Projects
None yet
2 participants
@arunchaganty
Contributor

arunchaganty commented Aug 26, 2012

I was looking to fix a usability issue; cabal would fail when given an empty http_proxy env variable. I replaced the proxy string extraction code with fetchProxy from HTTP (>=4000.0.8) and perform a check to see if the http_proxy string is empty - and if so, treat it as NoProxy. This should of course be the default behaviour of fetchProxy.

dcoutts added a commit that referenced this pull request Oct 29, 2012

@dcoutts dcoutts merged commit 4e43553 into haskell:master Oct 29, 2012

@dcoutts

This comment has been minimized.

Show comment Hide comment
@dcoutts

dcoutts Oct 29, 2012

Member

Looks great, thanks!

Member

dcoutts commented Oct 29, 2012

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment