Warnings and hlint cleanups #1094

Merged
merged 8 commits into from Nov 3, 2012

3 participants

@Peaker

A bunch of misc. cleanups of GHC 7.6 warnings and reported hlint issues in Cabal.

If this is welcome, I will continue the cleanup of Cabal and cabal-install.

@tibbe tibbe merged commit 90fae76 into haskell:master Nov 3, 2012
@tibbe
Haskell member

Clean-ups are always welcome. I wouldn't blindly apply hlint suggestions (not saying that you did). For example, sometimes eta-reducing expressions makes them harder to read. Also I would not make changes that are more subjective (e.g. changing the indentation amount used in a module) without discussing first (since we all have different preferences).

@23Skidoo
Haskell member

What does std stand for in stdParse?

The common subset of the standard language to specify benchmark/test in the .cabal file. Mechanical refactoring out repetition...

Haskell member

Can you make the name a bit more clear?

Sure, do you have any ideas for a better name?

It's there a standard name for cabal's language to describe tests and benchmarks?

Haskell member

It's there a standard name for cabal's language to describe tests and benchmarks?

Not sure, will have to think a bit more about it.

@23Skidoo
Haskell member

Nice! betweenSpaces is self-explanatory and can be useful on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment