Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement the 'run' command. #1097

Merged
merged 2 commits into from Nov 6, 2012

Conversation

Projects
None yet
2 participants
Member

23Skidoo commented Nov 5, 2012

This patch implements the run command, as discussed in #1088. I did not modify commandParseArgs, so -- is required for passing arguments to the executable.

Implement the 'run' command.
See the discussion in #1088.
Member

23Skidoo commented Nov 5, 2012

One issue: should we also make runhaskell Setup.hs run work?

+run verbosity buildFlags args = do
+ let distPref = fromFlagOrDefault (useDistPref defaultSetupScriptOptions)
+ (buildDistPref buildFlags)
+ -- The package must have been configured by now.
@tibbe

tibbe Nov 5, 2012

Owner

Do we output a sensible error message (like e.g. build does) if not?

@23Skidoo

23Skidoo Nov 5, 2012

Member

It uses the same mechanism as cabal test (i.e., reconfigure and build).

@23Skidoo

23Skidoo Nov 5, 2012

Member

So it prints the same error message as build. By the time we enter run, we know that all is well.

Owner

tibbe commented Nov 5, 2012

I think we can skip the support for Setup.hs for now.

Owner

tibbe commented Nov 5, 2012

Code looks good to me. I'll merge when I get home.

@dcoutts Do you think we should support ./Setup run as well, or do you want to move slower on adding commands to that UI (as it's more standardized)?

Member

23Skidoo commented Nov 5, 2012

Code looks good to me. I'll merge when I get home.

Great. In the meanwhile, I'll update the users' guide.

@tibbe tibbe merged commit bd8efdf into haskell:master Nov 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment