Add a 'no-threaded' flag to cabal-install.cabal #1132

Merged
merged 1 commit into from Nov 26, 2012

Conversation

Projects
None yet
2 participants
Member

23Skidoo commented Nov 23, 2012

Some platforms (e.g. ARM) don't have a threaded RTS, which makes it impossible
to build cabal-install without editing the source by hand (see #1129). This
patch makes life a bit easier for people using these platforms.

Alternatively, we could add a configure check instead of a flag, but that would
make building cabal-install harder on Windows.

Member

23Skidoo commented Nov 24, 2012

I can merge this myself, but I'm wondering whether others agree that not adding a configure script is the right solution. @dcoutts, what do you think?

Member

dcoutts commented Nov 26, 2012

I think the simplest hack is to use:

if !arch(arm)
  ghc-options: -threaded

Obviously it'd be more future proof to be able to base this on whether or not the particular ghc in question supports the threaded rts or not, but that's more of a general Cabal feature request. This will do for now I think.

@23Skidoo 23Skidoo Do not link with threaded RTS on ARM.
GHC on ARM doesn't have a threaded RTS, which makes it impossible to build
cabal-install without editing the source by hand (see #1129). This patch makes
cabal-install compile out of the box on ARM.
074691a
Member

23Skidoo commented Nov 26, 2012

@dcoutts Done.

@23Skidoo 23Skidoo added a commit that referenced this pull request Nov 26, 2012

@23Skidoo 23Skidoo Merge pull request #1132 from 23Skidoo/no-threaded
Do not link with threaded RTS on ARM.
87a97f4

@23Skidoo 23Skidoo merged commit 87a97f4 into haskell:master Nov 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment