Don't pass unsupported flags to setups built with old Cabal versions. #1133

Merged
merged 1 commit into from Nov 29, 2012

2 participants

@23Skidoo
Haskell member

We must not pass --disable-benchmarks to setup scripts built with Cabal < 1.14; the same is also true for --disable-tests and Cabal < 1.10.

Fixes #932 and #1004.

Without this patch:

$ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb
[...]
unrecognized option `--disable-benchmarks'
Failed to install syb-0.3.7

With this patch:

$ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb
[...]
Registering syb-0.3.7...
Installed syb-0.3.7
@23Skidoo 23Skidoo Don't pass unsupported flags to setups built with old Cabal versions.
We must not pass '--disable-benchmarks' to setup scripts built with Cabal <
1.14; the same is also true for '--disable-tests' and Cabal < 1.10.

Fixes #932 and #1004.

Without this patch:

    $ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb
    [...]
    unrecognized option `--disable-benchmarks'
    Failed to install syb-0.3.7

With this patch:

    $ cabal install -w /path/to/ghc-7.2.1/bin/ghc syb
    [...]
    Registering syb-0.3.7...
    Installed syb-0.3.7
582d12e
@tibbe tibbe merged commit 582d12e into haskell:master Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment