Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix build with GHC 6.12 #1154

Merged
merged 1 commit into from Dec 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

bmillwood commented Dec 17, 2012

These are the changes necessary for me to build Cabal on GHC 6.12.3. I can't run the test-suite with them because it fails even without my changes, but I think they're reasonably non-controversial (except that I can't find a good changelog for the time package, so I'm not certain there were no functionality changes we should be worried about, but I don't think so)

Contributor

bmillwood commented Dec 18, 2012

Update on the test situation: I managed, via some considerable effort, to get the unit tests running and passing on 6.12.3.

I can't get the package tests to run. I'm not yet sure why but I suspect it's something to do with HUnit invoking the wrong ghc version.

Contributor

bmillwood commented Dec 18, 2012

I managed to get the package tests to run at last – I needed to set GHC=ghc-6.12.3 in the environment, so that the various Setup.hs files were compiled with the right compiler. I feel like that ought to be done automatically, but I'm not going to lose sleep over it.

The result was three failures, but they're the same three failures I get running it on GHC 7.6.1, so I don't think they're to do with my patch.

Owner

tibbe commented Dec 18, 2012

I had to add the GHC environment variable to make it possible to run the test suite if you change the compiler using configure -w. Before the tests would just call the ghc executable on the path, even if it was different from the one the library was built with. It would be nice to improve this. We'd somehow need to figure out which GHC to use in the tests. Perhaps we could read the configure GHC from within dist/setup-config (I think that's the right file) in the test runner and make sure we call the right ghc and ghc-pkg executables.

@tibbe tibbe merged commit 3f72127 into haskell:master Dec 18, 2012

Contributor

bmillwood commented Dec 18, 2012

Yeah, don't get me wrong, I'm grateful the env var exists at all :) but it would indeed be nice to retrieve the setup-config information.

I opened #1156 to keep track of that idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment