New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress annoying missing haddock warning for whitelist (rts) #1231

Merged
merged 2 commits into from Mar 11, 2013

Conversation

Projects
None yet
3 participants
@kowey
Copy link
Contributor

kowey commented Mar 5, 2013

See https://plus.google.com/114991347543804898741/posts/9FbAWEuTFXN

Note: there seems to be a very similar chunk of code in cabal-install Distribution.Client.Haddock. Sounds like there's a refactor wanting to happen there? Not sure what the background is though.

kowey added some commits Mar 5, 2013

Suppress missing haddock warning for some packages.
Allow a hardcoded whitelist of packages (currently 'rts') to not have
haddocks. When building several packages together, the accumulation of
these spurious warnings can make it a bit harder to notice legitimate
errors.
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 6, 2013

@dcoutts, what do you think?

@dcoutts

This comment has been minimized.

Copy link
Member

dcoutts commented Mar 7, 2013

Looks fine to me.

The thing in cabal-install is about generating an index of all the packages you have installed. Yes, I guess there's some opportunity for sharing there. If anyone wants to do that, then follow the model we have for D.S.Program.*, e.g. the HcPkg and GHC modules there. They define program invocations and some handy utilities for calling the programs in various ways.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 11, 2013

@dcoutts

Looks fine to me.

I'm merging this in then. Opened ticket #1233 to remind us about the code duplication issue.

23Skidoo added a commit that referenced this pull request Mar 11, 2013

Merge pull request #1231 from kowey/kowey
suppress annoying missing haddock warning for whitelist (rts)

@23Skidoo 23Skidoo merged commit 4609f95 into haskell:master Mar 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment