New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building libraries, build c-sources separately for profiling. #1286

Merged
merged 1 commit into from Apr 24, 2013

Conversation

Projects
None yet
3 participants
@23Skidoo
Copy link
Member

23Skidoo commented Apr 24, 2013

Fixes #1284.

There is no need to do this for exes since they are always built in only one way.

One downside of this patch is that it increases the compilation time when building with '--enable-library-profiling'. An alternative solution would be to add a new field (e.g. 'c-sources-ffi') for non-Haskell sources that depend on the GHC "way".

When building libraries, build c-sources separately for profiling.
Fixes #1284.

There is no need to do this for exes since they are always built in only one
way.

One downside of this patch is that it increases the compilation time when
building with '--enable-library-profiling'. An alternative solution would be to
add a new field (e.g. 'c-sources-ffi') for non-Haskell sources that depend on
the GHC "way".
@dcoutts

This comment has been minimized.

Copy link
Member

dcoutts commented Apr 24, 2013

Ok, looks fine.

23Skidoo added a commit that referenced this pull request Apr 24, 2013

Merge pull request #1286 from 23Skidoo/c-sources-profiling
When building libraries, build c-sources separately for profiling.

@23Skidoo 23Skidoo merged commit ed00321 into haskell:master Apr 24, 2013

@23Skidoo 23Skidoo deleted the 23Skidoo:c-sources-profiling branch Apr 24, 2013

@rrnewton

This comment has been minimized.

Copy link
Member

rrnewton commented on d148336 Apr 24, 2013

Do we know what percentage of average compile time (for hackage packages) is spent building C libraries?

If this percentage is low, we should be ok.

This comment has been minimized.

Copy link
Member

23Skidoo replied Apr 24, 2013

@rrnewton Yes, it's probably not that big of a deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment