Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve update performance (#799) #1341
Thinking about this issue offline, it might be wise to die later in the program instead of when we get the 304 response because another coder might be surprised by the behavior.
I don't think there is currently any issue with the code since it only gets used in downloadIndex and fetchRepoTarball. It's probably safe in both since if the index already exists, we do not want to extract it again. And fetchRepoTarball does checks to see if we already have the package so it will skip calling downloadURI.
Let me know what you think.
Sure, since the purpose of your patch is to improve the performance it makes sense to skip unnecessary processing. I suggest modifying the return type of