Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Initial implementation of repl command #1404

Merged
merged 1 commit into from Aug 10, 2013

Conversation

Projects
None yet
4 participants
Member

dcoutts commented Jul 29, 2013

No support yet for ovreriding the ghci :reload command.
No support in build or repl for module/file targets.
Not yet tested with sandboxes.

Member

23Skidoo commented Jul 29, 2013

Great! I'll add the changes necessary for making this work with sandboxes.

Member

23Skidoo commented Jul 29, 2013

BTW, why did you choose to create a pull request instead of just applying this patch?

Member

dcoutts commented Jul 30, 2013

@23Skidoo hey, I'm fallible too!

You ask me to review your patches... am I allowed to ask the same in return? ;-)

Also, I've not tested it in the context of sandboxes, it has no tests etc etc.

Owner

tibbe commented Aug 6, 2013

Two minor comments. Otherwise LGTM. Feel free to merge.

Member

dcoutts commented Aug 6, 2013

Thanks, will make adjustments and merge.

BTW, I did look at doing the :reload in ghci part too but I discovered that currently ghci does not let you override builtin commands. I filed ticket http://ghc.haskell.org/trac/ghc/ticket/8113

@dcoutts dcoutts Initial implementation of repl command
No support yet for ovreriding the ghci :reload command.
No support in build or repl for module/file targets.
Not yet tested with sandboxes.
f05ebbc

@dcoutts dcoutts added a commit that referenced this pull request Aug 10, 2013

@dcoutts dcoutts Merge pull request #1404 from dcoutts/repl
Initial implementation of repl command
2d9215b

@dcoutts dcoutts merged commit 2d9215b into haskell:master Aug 10, 2013

@hvr hvr referenced this pull request in haskell/haskell-mode Aug 19, 2013

Closed

Add support for "cabal repl" process type #195

@hvr hvr added a commit to hvr/ghci-ng that referenced this pull request Aug 19, 2013

@hvr hvr Pass-thru `--info` and similar to support new "cabal repl" facility
This allows `ghci-ng` to be used in via the new "cabal repl" feature
(see haskell/cabal#1404) as in

  cabal repl --with-ghc=ghci-ng"

This workaround is needed as "cabal repl" calls "ghc --info" for
detecting properties of the installed GHC.
941fa17
Owner

hvr commented Aug 23, 2013

@dcoutts fyi, hvr/ghci-ng@f480f2e fixes GHCi, I've also released ghci-ng-7.6.3.4 in case you want to experiment with it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment