Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactoring: change the return type of 'InstallPlan.ready'. #1592

Merged
merged 1 commit into from Dec 4, 2013

Conversation

Projects
None yet
3 participants
Member

23Skidoo commented Nov 26, 2013

Introduce a new type ReadyPackage to represent packages that have all dependencies already installed. Make InstallPlan.ready return [ReadyPackage] instead of [(ConfiguredPackage, InstalledPackageInfo)].

ReadyPackage is probably not the best possible name; I'm open to suggestions.

phaazon commented Nov 26, 2013

ResolvedPackage, UsablePackage, CompletePackage (well that one is weird).

Member

23Skidoo commented Nov 26, 2013

I also considered InstallablePackage.

phaazon commented Nov 26, 2013

Yeah even better!

Member

23Skidoo commented Nov 26, 2013

Also: FullyConfiguredPackage, to emphasise similarity with ConfiguredPackage.

Refactoring: change the return type of 'InstallPlan.ready'.
Introduce a new type 'ReadyPackage' to represent packages that have all
dependencies already installed. Make 'InstallPlan.ready' return '[ReadyPackage]'
instead of '[(ConfiguredPackage, InstalledPackageInfo)]'.

Also fix a bug where 'cabal configure' didn't pass '--dependency' options to
'setup configure'.
Member

dcoutts commented Dec 4, 2013

Yes, looks good. Thanks.

23Skidoo added a commit that referenced this pull request Dec 4, 2013

Merge pull request #1592 from 23Skidoo/ready-package
Refactoring: change the return type of 'InstallPlan.ready'.

@23Skidoo 23Skidoo merged commit 5ba1542 into haskell:master Dec 4, 2013

@23Skidoo 23Skidoo deleted the 23Skidoo:ready-package branch Dec 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment