Skip to content

Avoid $TMPDIR / linker detection conflict in bootstrap.sh. [Fix for #1710.] #1711

Merged
merged 1 commit into from Mar 3, 2014

2 participants

@geoff-codes

Avoid $TMPDIR / linker detection conflict in bootstrap.sh. See #1673, resolves #1710.

@23Skidoo 23Skidoo commented on the diff Mar 2, 2014
cabal-install/bootstrap.sh
@@ -35,7 +39,8 @@ DEFAULT_PREFIX="${HOME}/.cabal"
done
# None found.
-[ ! -x `which "$CC"` ] &&
+# `command command -v` is ugly, but `which` is non-standard (see man 1 which).
@23Skidoo
Haskell member
23Skidoo added a note Mar 2, 2014

which is non-standard

Is this a problem in practice? This is not the only place in the script where which is used.

@geoff-codes
geoff-codes added a note Mar 3, 2014

Rarely, except when used with which -s (often missing), or if the version of which installed is the original perl version, and perl is missing or broken. I've seen it a handful of times. Feel free to omit.

@23Skidoo
Haskell member
23Skidoo added a note Mar 3, 2014

I think we'll continue to use which.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@23Skidoo 23Skidoo merged commit fb351fa into haskell:master Mar 3, 2014

1 check passed

Details default The Travis CI build passed
@23Skidoo
Haskell member
23Skidoo commented Mar 3, 2014

Merged, thanks!

@geoff-codes geoff-codes deleted the pullreq:bootstrap-sh-fix branch Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.