New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple remote-repos in parallel #2503

Merged
merged 3 commits into from Mar 28, 2015

Conversation

Projects
None yet
2 participants
@abhinav
Copy link
Contributor

abhinav commented Mar 28, 2015

Closes #2227

abhinav added some commits Mar 28, 2015

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 28, 2015

LGTM. Since there usually are not so many remote-repos (at most 2 in 99% cases, I think), having an option to control the number of threads is not so important. I'd also change the message from

Downloading the latest package list from $REPO0
Downloading the latest package list from $REPO1
...
Downloading the latest package list from $REPON

To

Downloading the latest package lists from $REPO0, $REPO1, ... $REPON
@abhinav

This comment has been minimized.

Copy link
Contributor

abhinav commented Mar 28, 2015

Comma separated list looks weird with 79 character wrapping:

Downloading the latest package lists from: stackage-nightly-2015-03-27,
stackage-lts-1.14, hackage.haskell.org

Changed to print a list if the number of remote repos is greater than 1.

Single remote-repo:

Downloading the latest package list from stackage-nightly-2015-03-27

Multiple remote-repos:

Downloading the latest package lists from:
- stackage-nightly-2015-03-27
- stackage-lts-1.14
- hackage.haskell.org
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 28, 2015

Comma separated list looks weird with 79 character wrapping:

Looks OK to me, but your solution is better.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 28, 2015

OK, merging. Thanks for your contribution!

23Skidoo added a commit that referenced this pull request Mar 28, 2015

Merge pull request #2503 from abhinav/parallel-update
Update multiple remote-repos in parallel

@23Skidoo 23Skidoo merged commit fe880b9 into haskell:master Mar 28, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@abhinav abhinav deleted the abhinav:parallel-update branch Mar 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment