New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uploadPasswordCmd to read hackage password from arbitrary program output #2506

Merged
merged 1 commit into from Mar 30, 2015

Conversation

Projects
None yet
2 participants
@strake
Copy link
Contributor

strake commented Mar 28, 2015

No description provided.

uploadCheck :: Flag Bool,
uploadUsername :: Flag Username,
uploadPassword :: Flag Password,
uploadPasswordCmd :: Flag [[Char]],

This comment has been minimized.

@23Skidoo

23Skidoo Mar 28, 2015

Member

Why not Flag [String]?

This comment has been minimized.

@strake

strake Mar 29, 2015

Contributor

I normally use [Char]. Cabal team prefers String?

This comment has been minimized.

@23Skidoo

23Skidoo Mar 29, 2015

Member

Yes, [String] is preferable.

@@ -952,12 +955,15 @@ uploadAction uploadFlags extraArgs globalFlags = do
globalFlags' = savedGlobalFlags config `mappend` globalFlags
tarfiles = extraArgs
checkTarFiles extraArgs
maybe_password <- case uploadPasswordCmd uploadFlags'
of Flag (xs:xss) -> Just . Password <$> getProgramInvocationOutput verbosity (simpleProgramInvocation xs xss)

This comment has been minimized.

@23Skidoo

23Skidoo Mar 28, 2015

Member

Please keep all lines <80 col long.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 28, 2015

This fails on Travis because older GHCs don't have <$> et al. in the Prelude.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 29, 2015

Still fails on Travis. You should put import Control.Applicative (pure, (<$>)) inside the #if !MIN_VERSION_base(4,8,0) block.

@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 29, 2015

Otherwise LGTM.

23Skidoo added a commit that referenced this pull request Mar 30, 2015

Merge pull request #2506 from strake/uploadPasswordCmd
add uploadPasswordCmd to read hackage password from arbitrary program output

@23Skidoo 23Skidoo merged commit 5413af5 into haskell:master Mar 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@23Skidoo

This comment has been minimized.

Copy link
Member

23Skidoo commented Mar 30, 2015

Merged, thanks!

@strake strake deleted the strake:uploadPasswordCmd branch Apr 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment