Fix deadlock in detailed-0.9 test suites #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #2489, but I still need to check if the |
|
This is strange; the deadlock is fixed on my machine, but not on Travis. The timing must be more sensitive than I thought. |
Fixes haskell#2489. The detailed-0.9 test suite runner would deadlock because the IO manager was not draining the output pipe of the child process. Thanks to @r0ml for the patch.
ttuegel
added a commit
that referenced
this pull request
Aug 9, 2015
Fix deadlock in detailed-0.9 test suites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test case first, waiting to see that Travis fails...