Additional warnings for 'cabal run'

[lspitzner]

see #2507

just additional warnings; did not implement anything in the direction of running test-suites or benchmarks (even thought that might be nice).

[23Skidoo]

I think it's simpler to just make this Maybe String and then use e.g. notice $ concat (maybeToList mbWarn ++ [myWarn]).

[lspitzner]

printMaybeWarningWithAdditional does not print anything if the warning-Maybe is Nothing, which you seem to have misunderstood in both your comments, or am i wrong?

[23Skidoo]

I guess the name tripped me up, perhaps a better one would be maybePrintWarning.... The first comment still applies, though. I think it's better to make maybeWarning a Maybe String and then do something like maybe (return ()) (notice verbosity) ((++ myMsg) <$> maybeWarning) in the code that uses it.

[lspitzner]

style question: traverse (notice normal) maybeWarning or notice normal traverse maybeWarning

[lspitzner]

(or was there a reason you preferred maybe?)

[23Skidoo]

style question: traverse (notice normal) maybeWarning or notice normal traverse maybeWarning

Whichever you prefer. Shouldn't it be traverse_, though?

(or was there a reason you preferred maybe?)

Nope, no problem with traverse.

[lspitzner]

.. yes, should be traverse_.

(and i thought i had -Wall configured..)

[23Skidoo]

BTW, there's a warn function for printing warnings.

[23Skidoo]

Merged, thanks!