Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a liberal import of Control.Exception to grab the new ErrorCall pattern in base #2786

Merged
merged 1 commit into from Aug 28, 2015

Conversation

Projects
None yet
3 participants
@bgamari
Copy link
Contributor

commented Aug 21, 2015

This is a prerequisite for GHC Phabricator D861.

@23Skidoo

This comment has been minimized.

Copy link
Member

commented Aug 21, 2015

Can't we do something like

#if __GLASGOW_HASKELL__ >= 711
import Control.Exception (pattern ErrorCall)
#endif

instead? Explicit imports give us forwards compat and help navigating code.

@bgamari

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2015

@gridaphobe, what say you? This sounds pretty reasonable IMHO.

@gridaphobe

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2015

Sure, that ought to work too (we'd also need to enable PatternSynonyms of course). I try to avoid using CPP personally, which is why I used the full import, but I don't have a strong opinion there.

(I'm not at my computer ATM so I haven't tried to compile anything)

@bgamari

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2015

@gridaphobe, do you think you could give this a shot?

@gridaphobe

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2015

Sure, I'll do it later today.

On Thu, Aug 27, 2015, at 06:25, Ben Gamari wrote:

@gridaphobe, do you think you could give this a shot?


Reply to this email directly or view it on GitHub:
#2786 (comment)

@gridaphobe gridaphobe force-pushed the gridaphobe:master branch from 01539ab to 99c4428 Aug 28, 2015

@gridaphobe

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2015

@23Skidoo is this better?

@bgamari I validated the new patch against the rest of D861, so we should be good to go once it's merged.

@23Skidoo

This comment has been minimized.

Copy link
Member

commented Aug 28, 2015

@gridaphobe Looks OK. You sure that the ErrorCall (..) import doesn't trigger a warning on GHC 7.11? We strive to be warning-free.

@gridaphobe gridaphobe force-pushed the gridaphobe:master branch from 99c4428 to 406a842 Aug 28, 2015

@gridaphobe

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2015

Ah, it did indeed, fixed!

@23Skidoo

This comment has been minimized.

Copy link
Member

commented Aug 28, 2015

Great, thanks. Merging.

23Skidoo added a commit that referenced this pull request Aug 28, 2015

Merge pull request #2786 from gridaphobe/master
use a liberal import of Control.Exception to grab the new ErrorCall pattern in base

@23Skidoo 23Skidoo merged commit ad11363 into haskell:master Aug 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.